Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lexical): #6132 react build size regression from #6088 #6133

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(lexical): #6132 react build size regression from #6088 #6133

merged 1 commit into from
May 17, 2024

Conversation

StyleT
Copy link
Contributor

@StyleT StyleT commented May 17, 2024 •
edited
Loading

Description

Changes are based on the 492816e by @etrepum

Closes: #6132

Test plan

Before

Screenshot 2024-05-17 at 3 42 25 PM

After

Screenshot 2024-05-17 at 3 47 11 PM

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 7:35pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 7:35pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.91 KB (0%) 479 ms (0%) 102 ms (+40.25% 🔺) 580 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.6 KB (0%) 693 ms (0%) 308 ms (+23.11% 🔺) 1000 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (0%) 691 ms (0%) 276 ms (+2.08% 🔺) 966 ms

@StyleT StyleT marked this pull request as ready for review May 17, 2024 19:47
@StyleT StyleT added the extended-tests Run extended e2e tests on a PR label May 17, 2024
@necolas
Copy link
Contributor

necolas commented May 17, 2024

Any idea why this doesn't show up in the size workflow report? There are no scripts run in that workflow, it all seems buried in some external action

@etrepum
Copy link
Collaborator

etrepum commented May 17, 2024

@necolas The size workflow report only measures three modules, none of them have any React dependencies. It never measured anything else. I did a full investigation in #6132.

https://github.com/facebook/lexical/blob/main/.size-limit.js#L55-L68

@StyleT StyleT added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit c1f0416 May 17, 2024
49 checks passed
@etrepum etrepum mentioned this pull request May 18, 2024
Closed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StyleT @necolas @etrepum @zurfyx @facebook-github-bot